Feature/insights remote lib #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge until uselagoon/lagoon-charts#578 is released |
timclifford
reviewed
Jul 28, 2023
cmd/gatherInCluster.go
Outdated
| //get the basic env vars | ||
| if argStatic && argDynamic { | ||
| log.Fatalf("Cannot use both 'static' and 'dynamic' only gatherers - exiting") | ||
| os.Exit(1) |
There was a problem hiding this comment.
No need for a os.Exit with the log.FatalF right?
gatherers/insights-remote-writer.go
Outdated
| insightsRemoteFacts.Facts = append(insightsRemoteFacts.Facts, f) | ||
| } | ||
|
|
||
| bodyString, _ := json.Marshal(insightsRemoteFacts) |
There was a problem hiding this comment.
might want to have some error handling to this in a few places below to
bodyString, err := json.Marshal(insightsRemoteFacts)
if err != nil {
return fmt.Errorf("failed to marshal insights remote facts: %w", err)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add an "in cluster" gatherer for the new insights remote webservice